Skip to content

fix(store): allow a generic reducer #2996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2021
Merged

fix(store): allow a generic reducer #2996

merged 1 commit into from
Apr 19, 2021

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #2982

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

While this works, I can't explain why ...😅

@alex-okrushko
Copy link
Member

while this works, I can't explain why ...😅

😂😂😂

alex-okrushko
alex-okrushko approved these changes Apr 19, 2021
View reviewed changes
modules/store/src/reducer_creator.ts
// This could be refactored when TS releases the version with this fix:
// https://github.com/microsoft/TypeScript/pull/41544
const reducer = args.pop() as OnReducer<State, Creators>;
const reducer = args.pop() as OnReducer<any, Creators>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const reducer = args.pop() as OnReducer<any, Creators>;
const reducer = args.pop() as OnReducer<unknown, Creators>;

Would that still work? 🙂

@brandonroberts brandonroberts merged commit 7da57bc into master Apr 19, 2021
@brandonroberts brandonroberts deleted the fix/generic-state branch April 19, 2021 21:27
@amakhrov amakhrov mentioned this pull request Jun 15, 2021
Closed
@preda7or preda7or mentioned this pull request Jun 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandonroberts brandonroberts brandonroberts approved these changes

@alex-okrushko alex-okrushko alex-okrushko approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support generic state

3 participants

@timdeschryver @alex-okrushko @brandonroberts