Skip to content

docs(tutorial): create todo app tutorial based on tutorial kit #2213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 20, 2024
Merged

docs(tutorial): create todo app tutorial based on tutorial kit #2213

merged 4 commits into from
Sep 20, 2024

Conversation

profanis
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@profanis profanis force-pushed the fp/tutorial-kit branch 2 times, most recently from fe373e8 to 96b4225 Compare August 28, 2024 05:30
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Aug 28, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c0e25d3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@bundlemon BundleMon
Copy link

bundlemon bot commented Aug 28, 2024 •
edited
Loading

BundleMon

Unchanged files (6)
Status Path Size Limits
✅ fesm2022/ngxs-store.mjs
 98.8KB 100KB / +0.5%
✅ fesm2022/ngxs-store-internals.mjs
 11.36KB 13KB / +0.5%
✅ fesm2022/ngxs-store-internals-testing.mjs
 6.83KB 7KB / +0.5%
✅ fesm2022/ngxs-store-operators.mjs
 6.22KB 7KB / +0.5%
✅ fesm2022/ngxs-store-plugins.mjs
 2.04KB 3KB / +0.5%
✅ fesm2022/ngxs-store-experimental.mjs
 1.4KB 2KB / +0.5%

No change in files bundle size

Unchanged groups (2)
Status Path Size Limits
✅ @ngxs/store(esm2022)[gzip]
./esm2022/**/*.mjs
 218.99KB +1%
✅ @ngxs/store(fesm2022)[gzip]
./fesm2022/*.mjs
 30.23KB +1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon BundleMon
Copy link

bundlemon bot commented Aug 28, 2024 •
edited
Loading

BundleMon (NGXS Plugins)

Unchanged files (9)
Status Path Size Limits
✅ Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin.m
js
 4.15KB +0.5%
✅ Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin.mjs
 3.2KB +0.5%
✅ Plugins(fesm2022)[gzip]
websocket-plugin/fesm2022/ngxs-websocket-plug
in.mjs
 2.64KB +0.5%
✅ Plugins(fesm2022)[gzip]
hmr-plugin/fesm2022/ngxs-hmr-plugin.mjs
 2.61KB +0.5%
✅ Plugins(fesm2022)[gzip]
form-plugin/fesm2022/ngxs-form-plugin.mjs
 2.59KB +0.5%
✅ Plugins(fesm2022)[gzip]
devtools-plugin/fesm2022/ngxs-devtools-plugin
.mjs
 2.23KB +0.5%
✅ Plugins(fesm2022)[gzip]
logger-plugin/fesm2022/ngxs-logger-plugin.mjs
 2.09KB +0.5%
✅ Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin-i
nternals.mjs
 875B +0.5%
✅ Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin-int
ernals.mjs
 411B +0.5%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
✅ All Plugins(fesm2022)[gzip]
./-plugin/fesm2022/.mjs
 20.76KB +0.5%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon BundleMon
Copy link

bundlemon bot commented Aug 28, 2024 •
edited
Loading

BundleMon (Integration Projects)

Unchanged files (3)
Status Path Size Limits
✅ Main bundles(Gzip)
hello-world-ng18/dist-integration/browser/mai
n-(hash).js
 71.66KB +1%
✅ Main bundles(Gzip)
hello-world-ng17/dist-integration/main.(hash)
.js
 68.56KB +1%
✅ Main bundles(Gzip)
hello-world-ng16/dist-integration/main.(hash)
.js
 67.58KB +1%

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@markwhitfeld
Copy link
Member

@profanis Please could you exclude the tutorials folder in the .codeclimate.yml file.
And add the rule to ignore the node_modules folder in the .eslintignore.

@profanis profanis marked this pull request as ready for review August 30, 2024 05:08
@profanis
Copy link
Contributor Author

@profanis Please could you exclude the tutorials folder in the .codeclimate.yml file. And add the rule to ignore the node_modules folder in the .eslintignore.

Thanks for that @markwhitfeld
I committed the changes

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 20, 2024

Open in Stackblitz

@ngxs/devtools-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/hmr-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/form-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/router-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/storage-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/store

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/websocket-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

commit: c0e25d3

@qlty-cloud-legacy Qlty Cloud (Legacy)
Copy link

Code Climate has analyzed commit c0e25d3 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.3% (0.0% change).

View more on Code Climate.

@markwhitfeld markwhitfeld merged commit 76347ef into master Sep 20, 2024
18 checks passed
@markwhitfeld markwhitfeld deleted the fp/tutorial-kit branch September 20, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markwhitfeld markwhitfeld markwhitfeld approved these changes

@arturovt arturovt Awaiting requested review from arturovt arturovt is a code owner

@kuncevic kuncevic Awaiting requested review from kuncevic kuncevic is a code owner

@Carniatto Carniatto Awaiting requested review from Carniatto Carniatto is a code owner

@poloagustin poloagustin Awaiting requested review from poloagustin poloagustin is a code owner

@joaqcid joaqcid Awaiting requested review from joaqcid joaqcid is a code owner

@splincode splincode Awaiting requested review from splincode splincode is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@profanis @markwhitfeld