Skip to content

refactor(store): drop share() operator #2340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2025
Merged

refactor(store): drop share() operator #2340

merged 1 commit into from
Jun 9, 2025

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented Jun 9, 2025 •
edited
Loading

People may not be using the share() operator at all in their application code, which means that a single usage of it in NGXS would cause the operator's code to be bundled into the main bundle. The parameterless share() can be safely replaced with a Subject for multicasting.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 9, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 66e5ffa.

Command Status Duration Result
nx run-many --target=test --all --configuration... ✅ Succeeded 2m 32s View ↗
nx run-many --target=lint --all --exclude=creat... ✅ Succeeded 6s View ↗
nx lint-types store ✅ Succeeded <1s View ↗
nx run-many --target=build --all ✅ Succeeded 1m 30s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-09 16:14:37 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 9, 2025

Open in StackBlitz

@ngxs/devtools-plugin

npm i https://pkg.pr.new/@ngxs/devtools-plugin@2340

@ngxs/form-plugin

npm i https://pkg.pr.new/@ngxs/form-plugin@2340

@ngxs/hmr-plugin

npm i https://pkg.pr.new/@ngxs/hmr-plugin@2340

@ngxs/router-plugin

npm i https://pkg.pr.new/@ngxs/router-plugin@2340

@ngxs/storage-plugin

npm i https://pkg.pr.new/@ngxs/storage-plugin@2340

@ngxs/store

npm i https://pkg.pr.new/@ngxs/store@2340

@ngxs/websocket-plugin

npm i https://pkg.pr.new/@ngxs/websocket-plugin@2340

commit: 66e5ffa

@bundlemon BundleMon
Copy link

bundlemon bot commented Jun 9, 2025

BundleMon

Files updated (1)
Status Path Size Limits
✅ fesm2022/ngxs-store.mjs
 100.55KB (+56B +0.05%) 105KB / +0.5%
Unchanged files (5)
Status Path Size Limits
✅ fesm2022/ngxs-store-internals.mjs
 13.78KB 15KB / +0.5%
✅ fesm2022/ngxs-store-internals-testing.mjs
 10.47KB 13KB / +0.5%
✅ fesm2022/ngxs-store-operators.mjs
 6.05KB 7KB / +0.5%
✅ fesm2022/ngxs-store-plugins.mjs
 2.38KB 3KB / +0.5%
✅ fesm2022/ngxs-store-experimental.mjs
 574B 2KB / +0.5%

Total files change +56B +0.04%

Unchanged groups (1)
Status Path Size Limits
✅ @ngxs/store(fesm2022)[gzip]
./fesm2022/*.mjs
 32.57KB +1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon BundleMon
Copy link

bundlemon bot commented Jun 9, 2025

BundleMon (NGXS Plugins)

Unchanged files (9)
Status Path Size Limits
✅ Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin.m
js
 3.95KB +0.5%
✅ Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin.mjs
 2.96KB +0.5%
✅ Plugins(fesm2022)[gzip]
hmr-plugin/fesm2022/ngxs-hmr-plugin.mjs
 2.63KB +0.5%
✅ Plugins(fesm2022)[gzip]
websocket-plugin/fesm2022/ngxs-websocket-plug
in.mjs
 2.56KB +0.5%
✅ Plugins(fesm2022)[gzip]
form-plugin/fesm2022/ngxs-form-plugin.mjs
 2.46KB +0.5%
✅ Plugins(fesm2022)[gzip]
devtools-plugin/fesm2022/ngxs-devtools-plugin
.mjs
 2.14KB +0.5%
✅ Plugins(fesm2022)[gzip]
logger-plugin/fesm2022/ngxs-logger-plugin.mjs
 2.01KB +0.5%
✅ Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin-i
nternals.mjs
 955B +0.5%
✅ Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin-int
ernals.mjs
 457B +0.5%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
✅ All Plugins(fesm2022)[gzip]
./-plugin/fesm2022/.mjs
 20.09KB +0.5%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon BundleMon
Copy link

bundlemon bot commented Jun 9, 2025

BundleMon (Integration Projects)

Files updated (1)
Status Path Size Limits
✅ Main bundles(Gzip)
hello-world-ng19/dist-integration/browser/mai
n-(hash).js
 66.29KB (+31B +0.05%) +1%

Total files change +31B +0.05%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@qlty-cloud-legacy Qlty Cloud (Legacy)
Copy link

Code Climate has analyzed commit 66e5ffa and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 94.0% (0.0% change).

View more on Code Climate.

@arturovt arturovt marked this pull request as ready for review June 9, 2025 16:16
@arturovt arturovt merged commit d141408 into master Jun 9, 2025
13 checks passed
@arturovt arturovt deleted the refactor/store-share branch June 9, 2025 16:16
@markwhitfeld
Copy link
Member

@arturovt What is the motivation for this change?
The bundle size actually increased slightly.

Can you update the description of the PR with the motivation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markwhitfeld markwhitfeld Awaiting requested review from markwhitfeld markwhitfeld is a code owner

@kuncevic kuncevic Awaiting requested review from kuncevic kuncevic is a code owner

@Carniatto Carniatto Awaiting requested review from Carniatto Carniatto is a code owner

@poloagustin poloagustin Awaiting requested review from poloagustin poloagustin is a code owner

@joaqcid joaqcid Awaiting requested review from joaqcid joaqcid is a code owner

@splincode splincode Awaiting requested review from splincode splincode is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arturovt @markwhitfeld