Clean up BacktrackingTM's public API #3645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes a couple of unused functions and removes many functions from the public API. In all cases where functions were moved from public to private, they were only used within the class itself, a test function, or a subclass of the class.
|
Can one of @scottpurdy @oxtopus @vitaly-krugl @mrcslws have a look at this? See #3644 for motivation. |
oxtopus
approved these changes
May 25, 2017
|
I did not run integration tests, which are failing. Fixing now. |
|
Well that was a shitty merge into my working branch. 🤕 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3644