BUG: Correctly identify comma separated dtype strings#10624
Merged
charris merged 1 commit intonumpy:maintenance/1.14.xfrom Feb 18, 2018
Merged
BUG: Correctly identify comma separated dtype strings#10624charris merged 1 commit intonumpy:maintenance/1.14.xfrom
charris merged 1 commit intonumpy:maintenance/1.14.xfrom
Conversation
When parsing dtype strings, we should only consider them to be comma seperated if there are commas not present in a pair of square brackets. Whilst we had a check for this already in the code there was an off by 1 bug where we failed to consider the first character of the string. This would lead to an infinite recursion when trying to parse strings of the form `[i8,f8]`. Fixes: numpy#10440
charris
added
00 - Bug
component: numpy._core
08 - Backport
eric-wieser
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #10623.
When parsing dtype strings, we should only consider them to
be comma seperated if there are commas not present in a
pair of square brackets.
Whilst we had a check for this already in the code there was
an off by 1 bug where we failed to consider the first character
of the string. This would lead to an infinite recursion when
trying to parse strings of the form
[i8,f8].Fixes: #10440