Skip to content

REL: Prepare for 1.14.1 release.#10630

Merged
charris merged 1 commit intonumpy:maintenance/1.14.xfrom
charris:prepare-1.14.1
Feb 20, 2018
Merged

REL: Prepare for 1.14.1 release.#10630
charris merged 1 commit intonumpy:maintenance/1.14.xfrom
charris:prepare-1.14.1

Conversation

@charris
Copy link
Member

@charris charris commented Feb 19, 2018

  • Update release notes.
  • Create 1.14.1-changelog.rst

[skip ci]

@charris charris added this to the 1.14.1 release milestone Feb 19, 2018
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: replace the could by that could.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps "is once more the default", or something emphasizing we're back to the 1.13 behavior?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was also in 1.13, indeed, since the axis parameter was introduced.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I mean is I think we should be explicit here that 1.14.1 restores the 1.13.3 behavior

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're choosing to leave this hidden then @ahaldane?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied the notes from master, probably this was only in the 1.14.x branch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this would be useful info for users, but if it's not part of the standard update-release-note I don't mind skipping it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added back part of this to the list of problems fixed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

* Update release notes.
* Create `1.14.1-changelog.rst`

[skip ci]
* The change in 1.14.0 that multi-field indexing of structured arrays returns a
view instead of a copy has been reverted but remains on track for NumPy 1.15.
Affected users should read the 1.14.1 Numpy User Guide section
"basics/structured arrays/accessing multiple fields" for advice on how to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get an rst link for this, so that the sphinx release note page links to it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately those docs are inside a .py file: numpy/doc/structured_arrays.py, so I'm not sure that will work out well.

https://github.com/numpy/numpy/blob/maintenance/1.14.x/numpy/doc/structured_arrays.py

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not over design this, it's just a release note. The documentation will go up after the release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to get rid of the *.py documentation files at some point. It is confusing to have the documentation scattered about like that.

@charris charris merged commit 7849751 into numpy:maintenance/1.14.x Feb 20, 2018
@charris charris deleted the prepare-1.14.1 branch February 20, 2018 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants