ENH: Pass optimizations arguments to asv build#17284
Conversation
|
@seberg, I just don't understand why ASV doesn't provide a direct way to specify custom build options? Am I missing something? |
|
I looked around a bit, and don't see a way other than as part of the config. However, we could use |
|
I think this is a good solution to benchmark flexible universal intrinsic usage. but asv community still needs to considering the necessity of adding |
4fcf2bb to
6edbba2
Compare
I confirm it, thank you!
I followed your suggestion, I kept the main config file as-is so it can be used with
An effective workaround but we still have other obstacles such as providing auto-generated test data and |
|
Maybe its right and we should consider upstreaming things to ASV. I am a bit worried that running plain ASV won't have access to this, but there may not be a good way to do that. |
No, it generates a config file with the required build options then pass it through |
I didn't touch the original config file, I created a new asv config instead |
This patch allows passing `-j`, `--cpu-baseline`, `--cpu-dispatch` and `--disable-optimization` to ASV build when argument `--bench-compare` is used.
9504077 to
96be695
Compare
seiko2plus
left a comment
There was a problem hiding this comment.
Looks good to me, what do you think @pv?
|
This needs documentation so people will know how to use it. Maybe in the |
|
Thanks Sayed. I put this in to aid the ongoing SIMD work, but more usage documentation would be helpful. |
ENH: Pass optimizations arguments to asv build #17284
This patch allows passing
-j,--cpu-baseline,--cpu-dispatchand--disable-optimizationto ASV build when argument
--bench-compareis used.TODO: