MAINT: Replace setting of array shape by reshape operation #29314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eendebakpt
changed the title
seberg
approved these changes
Jul 31, 2025
There was a problem hiding this comment.
Thanks, nice cleanup @eendebakpt and even better if it helps with the deprecation :).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #28800.
In this PR we replace some explicit setting of the
shapeof an array in favor of usingreshape. Some cases are left out (e.g. masked arrays, tests to check the.shapesetting works).In followup PRs the remaining cases will be handled and the shape setting deprecated.