MAINT: remove unnecessary kwargs update in MaskedArray.reshape
#29403
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorenham
reviewed
Jul 21, 2025
jorenham
approved these changes
Jul 21, 2025
|
Agreed, seems rather useless and any reasonable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on the type annotations for
MaskedArray.reshapeand looked into the implementation, and noticed there's an unnecessary update tokwargsThe line
numpy/numpy/ma/core.py
Line 4821 in 75e86ba
sets
'C'as the default iforderwasn't passed, else it keeps what the user passed. This then gets passed tondarray.reshapeinnumpy/numpy/ma/core.py
Line 4822 in 75e86ba
and
numpy/numpy/ma/core.py
Line 4826 in 75e86ba
However,
order='C'is already the default forndarray.reshapenumpy/numpy/_core/fromnumeric.py
Lines 209 to 210 in 8cf1f7d