Skip to content

TYP: Remove MaskedArray.__reduce__, and punt on MaskedArray.__{eq,ne}__ #29470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 30, 2025

Conversation

MarcoGorelli
Copy link
Member

No description provided.

@MarcoGorelli MarcoGorelli marked this pull request as ready for review July 29, 2025 18:05
@jorenham jorenham self-requested a review July 30, 2025 00:00
@jorenham jorenham added the component: numpy.ma masked arrays label Jul 30, 2025
Copy link
Member

@jorenham jorenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, it's also fine to just remove the 🥒 methods; they probably won't be used directly, and they're already annotated in object:

https://github.com/python/typeshed/blob/7beac2529cc23576bbb7f74e7d64aa4d0ca8c6f7/stdlib/builtins.pyi#L129-L134

@MarcoGorelli MarcoGorelli changed the title TYP: Type MaskedArray.__reduce__, and punt on MaskedArray.__{eq,ne}__ TYP: Remove MaskedArray.__reduce__, and punt on MaskedArray.__{eq,ne}__ Jul 30, 2025
@jorenham jorenham merged commit 75169a9 into numpy:main Jul 30, 2025
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants