Draft: [DEP] Deprecate setting the shape attribute of a numpy array #29492
+58
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorenham
reviewed
Jul 31, 2025
Comment on lines
+2172
to
2173
| @deprecated("Setting the shape on a NumPy array has been deprecated in NumPy 2.4") | ||
| @shape.setter |
There was a problem hiding this comment.
I'm not sure why, but my instinct tells me that these two should be swapped
Suggested change
| @deprecated("Setting the shape on a NumPy array has been deprecated in NumPy 2.4") | |
| @shape.setter | |
| @shape.setter | |
| @deprecated("Setting the shape on a NumPy array has been deprecated in NumPy 2.4") |
That's probably because I know from experience that this way it'll work for both mypy and pyright, whereas I'm not sure about the other way around. But then again, maybe it doesn't matter 🤷🏻
There was a problem hiding this comment.
I followed the style a couple of lines below for strides.setter. Could you check how this works with mypy and pyright?
There was a problem hiding this comment.
mypy indeed doesn't seem to like it this way:
Swapping them seems to help:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #28800.