Skip to content

ENH: Use extern C in arraytypes.h.src file for cpp files #29504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025

Conversation

ixgbe
Copy link
Contributor

@ixgbe ixgbe commented Aug 4, 2025

Refer to 63d6f65

Planned: Convert argfunc.dispatch.c.src to argfunc.dispatch.cpp to enable C++ language features and improve code maintainability.

@ngoldbaum
Copy link
Member

LGTM! Especially given loops.h.src still works in C++ and also uses the .c.src templating.

Actually doing a C++ conversion on arraytypes.h to use e.g. template functions will also require converting item_selection.c and multiarraymodule.c which will probably not happen for a while, so we probably won't be able to replace the .c.src templating in the header here.

Planned: Convert argfunc.dispatch.c.src to argfunc.dispatch.cpp to enable C++ language features and improve code maintainability.

Nice! That seems like a good isolated choice to start with.

@ngoldbaum ngoldbaum merged commit ae77211 into numpy:main Aug 4, 2025
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants