Skip to content

DEP: Deprecate setting the shape attribute of an exact numpy array #29523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
+92 −93
Open

DEP: Deprecate setting the shape attribute of an exact numpy array #29523

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
98264cb
[DEP] Deprecate setting the shape attribute of a numpy array
eendebakpt Jul 31, 2025
27ef5f2
add release note
eendebakpt Jul 31, 2025
b7842a8
update tests
eendebakpt Jul 31, 2025
9af1e83
more conversions
eendebakpt Jul 31, 2025
1695917
convert more tests
eendebakpt Aug 6, 2025
1d71fc5
ma
eendebakpt Aug 6, 2025
e8cbd57
fix generator and mrecords
eendebakpt Aug 6, 2025
354a04e
review comments
eendebakpt Aug 6, 2025
bea4884
remove debugging code
eendebakpt Aug 6, 2025
5c8a65e
remove examples
eendebakpt Aug 7, 2025
914462d
restore examples wiht only get of shape
eendebakpt Aug 7, 2025
7e06ce2
remove doc with deprecated shape setting
eendebakpt Aug 7, 2025
2e80bf0
update release note
eendebakpt Aug 7, 2025
1d086e8
Merge branch 'main' into deprecate_shape_v2
eendebakpt Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove debugging code
  • Loading branch information
@eendebakpt
eendebakpt committed Aug 6, 2025
commit bea4884d26562537bb9fcc1841b1f98c1b558e03
2 changes: 1 addition & 1 deletion numpy/ma/tests/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1368,7 +1368,7 @@ def test_minmax_reduce(self):
def test_minmax_funcs_with_output(self):
# Tests the min/max functions with explicit outputs
mask = np.random.rand(12).round()
xm = array(np.random.uniform(0, 10, 12), mask=mask).reshape((3,4))
xm = array(np.random.uniform(0, 10, 12), mask=mask).reshape((3, 4))
for funcname in ('min', 'max'):
# Initialize
npfunc = getattr(np, funcname)
Expand Down
2 changes: 0 additions & 2 deletions numpy/matrixlib/defmatrix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,10 +189,8 @@ def __array_finalize__(self, obj):
else:
newshape = self.shape
if ndim == 0:
import sys; print(f'self refcount: {sys.getrefcount(self)}')
self.shape = (1, 1)
elif ndim == 1:
import sys; print(f'self refcount: {sys.getrefcount(self)}')
self.shape = (1, newshape[0])
return

Expand Down
Loading