Skip to content

Conversation

melissawm
Copy link
Member

@8bitmp3 please check - I had to do some tweaking to the format to make it work with MyST.

One problem remains: the gif is not showing properly. I'm trying to find a solution to this.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@melissawm melissawm marked this pull request as draft November 30, 2020 22:36
README.md Outdated
@@ -19,6 +19,7 @@ or navigate to any of the documents listed below and download it individually.
2. [Tutorial: CS231n Python Tutorial](content/cs231_tutorial.md)
3. [Tutorial: Determining Moore's Law with real data in NumPy](content/mooreslaw-tutorial.ipynb)
4. [Tutorial: Saving and sharing your NumPy arrays](content/save-load-arrays.ipynb)
5. [Tutorial: X-ray image processing](content/tutorial-x-ray-image-processing.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@melissawm Just noticed that the MNIST tutorial is also 5th in the list fyi

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was waiting for that one to be merged to fix this, thanks for catching that :)

Copy link
Collaborator

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty of adding the missing imageio dependency so that the CI can run successfully (we may need to adjust the myst_nb config params so that failed notebook execution fails more loudly!)

Just some comments on a few MyST gotchas, mostly related to markdown being picky about dashes/numbers & spacing.

I limited my comments to the format-specific stuff and not the content of the tutorial itself - I'll take another pass once this is merged so that I can add comments with the new workflow!

Copy link
Collaborator

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (once the merge conflict is resolved)! Thanks @melissawm & @8bitmp3 for taking the lead on the workflow conversion here,

@melissawm melissawm marked this pull request as ready for review December 11, 2020 22:06
@melissawm melissawm merged commit 003d874 into numpy:master Dec 11, 2020
melissawm added a commit that referenced this pull request Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants