Remove checks for unexpected reference depth
#1392
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my opinion, this check doesn't seem to be providing much value, and we've got a few folks requesting this be disabled. Instead of gating this behind a feature flag, we'll just remove it. Closes #1348.
|
Requires we actually inspect what's at that path and reference that |
|
@jamietanna Any news on this? I'm still encountering the error in question. |
|
@jhawrefvem please can you raise an issue (https://github.com/oapi-codegen/oapi-codegen/blob/main/CONTRIBUTING.md#raising-a-bug) for this? This may now be closed by #1689 and some follow up changes |
|
When to merge this to main branch? |
|
If you're still seeing issues with this, please raise an issue, as this may not be an issue any more due to other changes we've made over time @moemoequte |
|
@jamietanna I put the problem I met in this pull request #1950 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unexpected reference depthCloses #1348.