feat(x-deprecated-reason): add default deprecation message #2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jamietanna
commented
Jul 15, 2025
jamietanna
commented
- chore: rename variable
- chore(examples): add a deprecated field without any reason
- feat(x-deprecated-reason): add default deprecation message
Kusari Analysis ResultsAnalysis for commit: c50a3d6, performed at: 2025-07-15T10:44:34Z • • Recommendation✅ PROCEED with this Pull Request Summary✅ No Flagged Issues Detected All values appear to be within acceptable risk parameters. No pinned version dependency changes, code issues or exposed secrets detected! Found this helpful? Give it a 👍 or 👎 reaction! |
In the case that we have a field deprecated, but no reason, the deprecation comment isn't ideal. Let's document it now, and improve it afterwards.
In the case that we have a field deprecated, but no reason, the deprecation comment isn't ideal. We can improve this by adding a default message in the case of no `x-deprecated-reason`.
jamietanna
force-pushed
the
tests/preferskipoptionalpointer
branch
from
63821a9 to
c50a3d6
Compare
|
Kusari PR Analysis rerun based on - c50a3d6 performed at: 2025-07-15T10:44:34Z - link to updated analysis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.