Fix server variables conflict #2045
Conversation
Kusari Analysis ResultsAnalysis for commit: cd507af, performed at: 2025-07-25T18:20:01Z • • Recommendation✅ PROCEED with this Pull Request Summary✅ No Flagged Issues Detected All values appear to be within acceptable risk parameters. No pinned version dependency changes, code issues or exposed secrets detected! Found this helpful? Give it a 👍 or 👎 reaction! |
|
Nice, thank you! |
There was a problem hiding this comment.
Can we please revert the unrelated changes? Although those full stops at the end may be reasonable, I'd prefer to remove them from this PR to keep it atomic. Thanks!
There was a problem hiding this comment.
Sure, that's done. I did leave a typo fix.
acm19
force-pushed
the
fix-server-variables-conflict
branch
from
524b078 to
4b52cc6
Compare
|
Kusari PR Analysis rerun based on - 4b52cc6 performed at: 2025-07-25T18:19:32Z - link to updated analysis |
Adds a property to opt-in avoiding the default value colliding with the value `default` for enum server variables. When set to true `Enum` is added to the variable name so that it doesn't clash with the default variable name. This behaviour is opt-in to avoid backward compatibility, but the default is actually a bug, so it make sense to change that default in the next major release. Resolves: oapi-codegen#2003
acm19
force-pushed
the
fix-server-variables-conflict
branch
from
4b52cc6 to
cd507af
Compare
|
Kusari PR Analysis rerun based on - cd507af performed at: 2025-07-25T18:20:01Z - link to updated analysis |
Adds a property to opt-in avoiding the default value colliding with the value
defaultfor enum server variables. When set to trueEnumis added to the variable name so that it doesn't clash with the default variable name. This behaviour is opt-in to avoid backward compatibility, but the default is actually a bug, so it make sense to change that default in the next major release.Resolves: #2003