Allow _DjangoMiddleware
to have span creation overridden
#3652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I had a need to dictate how the span creation would happen, specifically because the span I wanted to be the root was at the gunicorn worker level, not Django nor WSGI. Main reason was to include its request log in the trace.
Also, in our context, one span is enough to wrap gunicorn, WSGI and
_DjangoMiddleware
(for billing and practical purposes), so had WSGI and_DjangoMiddleware
contribute with their attributes to the span created by gunicorn.I had to override the entirety of
_DjangoMiddleware.process_request
in order to reuse the existing span and to avoidend_on_exit
that's currently hardcoded to true.This
_DjangoMiddleware._get_span
will allow achieving this behavior without such wide override.Type of change
How Has This Been Tested?
instrumentation/opentelemetry-instrumentation-django/tests/test_middleware.py
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.