Skip to content

Add all known file extensions #16050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

MKamelEJ
Copy link

@MKamelEJ MKamelEJ commented Jul 26, 2025

Pull Request Checklist

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests to validate the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • Add the known file formats based on the list of file extensions known by github, this list is nearly 1:1 mapping between them but extracted using python

Added

  • Updated the known file formats based on the list of file extensions known by github, This will prevent sending these formats to conversion tools like docling, which will not be able to handle these formats.

Data source

https://github.com/github-linguist/linguist/blob/main/lib/linguist/languages.yml

Extraction script:

import yaml

def extract_extensions(input_file, output_file):
    with open(input_file, 'r', encoding='utf-8') as f:
        content = f.read()

    # Parse the YAML-like structure
    data = yaml.safe_load(content)

    # Collect extensions without leading dots
    extensions = []
    for lang, props in data.items():
        if 'extensions' in props:
            for ext in props['extensions']:
                clean_ext = ext.lstrip('.')  # Remove leading dot
                extensions.append(clean_ext)

    # Remove duplicates and sort
    extensions = sorted(set(extensions))

    # Write to output file as a Python list
    with open(output_file, 'w', encoding='utf-8') as f:
        f.write("extensions = [\n")
        for ext in extensions:
            f.write(f"    '{ext}',\n")
        f.write("]\n")

# Example usage
extract_extensions('languages.yml', 'extensions.py')`

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

@MKamelEJ
Copy link
Author

MKamelEJ commented Jul 26, 2025

There are other alternatives to this list:

  1. Put these formats in a separate file (Code Quality), I see other opensource projects keep the list in the same file so not sure which is best.
  2. Copy the languages.yml file directly in the repository and use it, Not sure about licensing https://github.com/github-linguist/linguist/blob/main/LICENSE
  3. In case the conversion is not supported by tools like docling fall back to just attaching the file as is to the LLMs.

@rgaricano
Copy link
Contributor

These are different things, just because Github supports these file extensions doesn't mean they are text files that can be parsed by content extraction engines.

@MKamelEJ
Copy link
Author

MKamelEJ commented Jul 27, 2025

@rgaricano , You are correct, maybe a filter based on "type" or "acemode" would work ?
# type - Either data, programming, markup, prose, or nil

Also, the idea is that these files are not to be provided to the content extraction engine, For example in case of docling passing a .kt (Kotlin) file now would cause this, because it is not a supported format and in the list of text formats its not considered a text format, in this change the .kt file is now going to be considered a text file
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants