Clarify the Range header on a chunked push response #581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudo-bmitch
requested review from
dmcgowan,
jdolitsky,
jonjohnsonjr,
jzelinskie,
mikebrow and
stevvooe
as code owners
|
@rchincha when Zot has a new release, let me know and I'll update that to resolve the failing checks. |
rchincha
added a commit
to rchincha/zot
that referenced
this pull request
Jul 30, 2025
regclient/regclient#961 opencontainers/distribution-spec#581 Previously, zot returned the size of the currently uploaded chunk. Other registries the size of the entire blob. Align with the latter behavior. Signed-off-by: Ramkumar Chinchani <[email protected]>
rchincha
added a commit
to rchincha/zot
that referenced
this pull request
Jul 30, 2025
regclient/regclient#961 opencontainers/distribution-spec#581 Previously, zot returned the size of the currently uploaded chunk. Other registries the size of the entire blob. Align with the latter behavior. Signed-off-by: Ramkumar Chinchani <[email protected]>
rchincha
added a commit
to project-zot/zot
that referenced
this pull request
Jul 31, 2025
regclient/regclient#961 opencontainers/distribution-spec#581 Previously, zot returned the size of the currently uploaded chunk. Other registries the size of the entire blob. Align with the latter behavior. Signed-off-by: Ramkumar Chinchani <[email protected]>
sudo-bmitch
force-pushed
the
pr-chunked-range-header
branch
from
e7ed8af to
f3004a8
Compare
|
The update from Zot has been applied and this is ready for review. |
rchincha
reviewed
Aug 4, 2025
tianon
approved these changes
Aug 6, 2025
This clarifies the Range header response should be the range of the entire blob and not the last received chunk. Signed-off-by: Brandon Mitchell <[email protected]>
sudo-bmitch
force-pushed
the
pr-chunked-range-header
branch
from
f3004a8 to
d9f703c
Compare
|
I updated this to add the clarification on the GET response, and also to better identify the "response" part of the patch API. @mikebrow please include any further edits you would like to see. |
dmcgowan
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This clarifies the Range header response should be the range of the entire blob and not the last received chunk.
Fixes #580