Reload spec file(s) after every action #2532
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Even after actions that return some output because even those can modify spec files. Reload the dist-git spec file also after manipulating the repo for PR creation/update. Signed-off-by: Nikola Forró <[email protected]>
Contributor
|
Build failed. ✔️ pre-commit SUCCESS in 2m 07s |
softwarefactory-project-zuul bot
added a commit
that referenced
this pull request
Apr 4, 2025
… fixture (#2580) Initiate dist-git repo after spec file is present in `cockpit_ostree` fixture The spec file is copied to the dist-git repo after it is initialized, which means it isn't commited to git and eventually gets removed, but that doesn't make the tests fail because the related Specfile instance keeps its content in memory even though the file no longer exists. That however changes once the Specfile instance gets properly reloaded when needed and the tests start to fail. Fix that. Related to #2532, packit/specfile#458. Reviewed-by: Laura Barcziová Reviewed-by: Matej Focko
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even after actions that return some output because even those can modify spec files.
Reload the dist-git spec file also after manipulating the repo for PR creation/update.
Related to #2521.