Skip to content

test on trio, fix all missing aclose related warnings #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 11, 2024
Merged

test on trio, fix all missing aclose related warnings #1960

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5d7d4e2
test on trio
graingert Apr 8, 2024
5c47da8
avoid an unclosed auto_aiter
graingert Apr 7, 2024
0cb1dbd
test getting the first item from generate_async
graingert Apr 8, 2024
dd320dc
return an aclose-able AsyncGenerator from Template.generate_async
graingert Apr 7, 2024
8e81d7e
aclose root_render_func in generate_async
graingert Apr 7, 2024
6561a6c
use an older version of trio with py3.7 support
graingert Apr 8, 2024
a69175c
test includes, blocks and extends with generate_async
graingert Apr 8, 2024
0309293
(a)close generators when delgating to template blocks and includes
graingert Apr 7, 2024
6b04b6f
run test_async_filters under trio, and ensure async generators are cl…
graingert Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
return an aclose-able AsyncGenerator from Template.generate_async 
Fixes #1955
  • Loading branch information
@graingert @davidism
graingert authored and davidism committed May 11, 2024
commit dd320dc3d11364cd42799308b01a5776618ffb23
2 changes: 2 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ Unreleased
- Calling sync ``render`` for an async template uses ``asyncio.run``.
:pr:`1952`
- Avoid unclosed ``auto_aiter`` warnings. :pr:`1960`
- Return an ``aclose``-able ``AsyncGenerator`` from
``Template.generate_async``. :pr:`1960`


Version 3.1.4
Expand Down
2 changes: 1 addition & 1 deletion src/jinja2/environment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1346,7 +1346,7 @@ async def to_list() -> t.List[str]:

async def generate_async(
self, *args: t.Any, **kwargs: t.Any
) -> t.AsyncIterator[str]:
) -> t.AsyncGenerator[str, object]:
"""An async version of :meth:`generate`. Works very similarly but
returns an async iterator instead.
"""
Expand Down