Skip to content

BUG: PeriodIndex.searchsorted accepting invalid inputs #30763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 8, 2020
Merged

BUG: PeriodIndex.searchsorted accepting invalid inputs #30763

merged 8 commits into from
Jan 8, 2020

Conversation

jbrockmendel
Copy link
Member

also a bug in DataFrame.asof with a PeriodIndex returning an incorrectly-named Series.

@WillAyd
Copy link
Member

WillAyd commented Jan 7, 2020

Looks good. Maybe add a whatsnew in the off chance user code was expecting this to pass silently?

@WillAyd WillAyd added the Period Period data type label Jan 7, 2020
WillAyd
WillAyd approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WillAyd WillAyd added this to the 1.0 milestone Jan 7, 2020
@jreback jreback merged commit 511a284 into pandas-dev:master Jan 8, 2020
@jreback
Copy link
Contributor

jreback commented Jan 8, 2020

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the ref-searchsorted-pi branch January 8, 2020 18:17
@jbrockmendel jbrockmendel mentioned this pull request Jan 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Period Period data type
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @WillAyd @jreback