Skip to content

DEPR: Add deprecation warning for factorize() order keyword #19751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 21, 2018
Merged

DEPR: Add deprecation warning for factorize() order keyword #19751

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
261044a
[Utils][Warnings] Add deprecation warning for factorize() keyword, or…
EricChea Feb 18, 2018
ab47916
PR review for deprecating keyword, order, from factorize().
EricChea Feb 20, 2018
616c357
Add examples of how to deprecate a keyword, and fix spacing.
EricChea Feb 20, 2018
18eb031
doc
jreback Feb 20, 2018
6a34d9e
Add to what's new: deprecation of keyword ability, and warning when o…
EricChea Feb 20, 2018
4c83659
Change '|' to 'or' in docs.
EricChea Feb 20, 2018
1b10ca2
Merge branch 'master' into dep_keyword
EricChea Feb 20, 2018
b5daae0
Remove deprecate_kwarg util changes from whats new.
EricChea Feb 20, 2018
bd9717e
doc
jreback Feb 21, 2018
b7ed3c4
Merge branch 'master' into PR_TOOL_MERGE_PR_19751
jreback Feb 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into dep_keyword
  • Loading branch information
@EricChea
EricChea authored Feb 20, 2018
commit 1b10ca2b9a193ac268bdd50035752f0ab433ca61
3 changes: 1 addition & 2 deletions doc/source/whatsnew/v0.23.0.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,8 +588,7 @@ Other API Changes
- ``KeyError`` now raises instead of ``ValueError`` in :meth:`~DataFrame.drop`, :meth:`~Panel.drop`, :meth:`~Series.drop`, :meth:`~Index.drop` when dropping a non-existent element in an axis with duplicates (:issue:`19186`)
- :func:`Series.to_csv` now accepts a ``compression`` argument that works in the same way as the ``compression`` argument in :func:`DataFrame.to_csv` (:issue:`18958`)
- Set operations (union, difference...) on :class:`IntervalIndex` with incompatible index types will now raise a ``TypeError`` rather than a ``ValueError`` (:issue:`19329`)
- :class:`DateOffset` objects render more simply, e.g. "<DateOffset: days=1>" instead of "<DateOffset: kwds={'days': 1}>" (:issue:`19403`)
- :func:`pandas.merge` provides a more informative error message when trying to merge on timezone-aware and timezone-naive columns (:issue:`15800`)
- :class:`DateOffset` objects render more simply, e.g. ``<DateOffset: days=1>`` instead of ``<DateOffset: kwds={'days': 1}>`` (:issue:`19403`)
- :func:`util._decorators.deprecate_kwarg` now has the ability to deprecate a keyword entirely. Previously, using ``@deprecate_kwarg`` required that an alternative keyword be provided in favor of the deprecated keyword.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not needed to add this to the whatsnew docs, since this is private functionality. So the deprecation warning about order itself is enough.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Please refer to b5daae0


.. _whatsnew_0230.deprecations:
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.