Skip to content

Fix pd.merge to preserve ExtensionArrays dtypes #20745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 22, 2018
Merged

Fix pd.merge to preserve ExtensionArrays dtypes #20745

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
73d64eb
Fix pd.merge to preserve ExtensionArrays dtypes
jorisvandenbossche Apr 19, 2018
716e928
Fixed order.
TomAugspurger Apr 20, 2018
8824a47
Added issue number
TomAugspurger Apr 20, 2018
884510c
copy: check for arrays
jorisvandenbossche Apr 20, 2018
9cf8cfe
change order in tests for python < 3.6
jorisvandenbossche Apr 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
copy: check for arrays
  • Loading branch information
@jorisvandenbossche
jorisvandenbossche committed Apr 20, 2018
commit 884510c15a11d69af4ce8d2113377b3de1eabbdd
10 changes: 8 additions & 2 deletions pandas/core/internals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5541,8 +5541,14 @@ def concatenate_join_units(join_units, concat_axis, copy):
if len(to_concat) == 1:
# Only one block, nothing to concatenate.
concat_values = to_concat[0]
if copy and getattr(concat_values, 'base', 1) is not None:
concat_values = concat_values.copy()
if copy:
if isinstance(concat_values, np.ndarray):
# non-reindexed (=not yet copied) arrays are made into a view
# in JoinUnit.get_reindexed_values
if concat_values.base is not None:
concat_values = concat_values.copy()
elif:
concat_values = concat_values.copy()
else:
concat_values = _concat._concat_compat(to_concat, axis=concat_axis)

Expand Down