Skip to content

DEPR: deprecate default of skipna=False in infer_dtype #24050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jan 4, 2019
Merged

DEPR: deprecate default of skipna=False in infer_dtype #24050

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
2c9e2ea
DEPR: switch default of skipna-kwarg in infer_dtype to True
h-vetinari Dec 2, 2018
9d2da42
Merge remote-tracking branch 'upstream/master' into infer_skipna
h-vetinari Dec 5, 2018
21f7963
Change default of skipna to None & warn; add whatsnew
h-vetinari Dec 6, 2018
568bfd9
Missed one
h-vetinari Dec 6, 2018
4900f4b
Merge remote-tracking branch 'upstream/master' into infer_skipna
h-vetinari Dec 14, 2018
8c3c5b4
Review (jreback)
h-vetinari Dec 14, 2018
698b0d0
Merge remote-tracking branch 'upstream/master' into infer_skipna
h-vetinari Dec 19, 2018
52616b0
Fix new occurrence of infer_dtype
h-vetinari Dec 19, 2018
d72dbda
Merge remote-tracking branch 'upstream/master' into infer_skipna
h-vetinari Dec 21, 2018
245b7bc
Fix overlooked merge artefact
h-vetinari Dec 21, 2018
4d97ce8
Merge remote-tracking branch 'upstream/master' into infer_skipna
h-vetinari Jan 2, 2019
18e7bc6
Merge remote-tracking branch 'upstream/master' into infer_skipna
h-vetinari Jan 3, 2019
72ba292
Oversight
h-vetinari Jan 3, 2019
ebd1063
Add kwarg to new call-sites
h-vetinari Jan 3, 2019
e287bd8
and another new call-site
h-vetinari Jan 3, 2019
1ea21fe
Try skipna=True for new call-sites
h-vetinari Jan 3, 2019
fd8c010
Revert skipna=True where it was added
h-vetinari Jan 3, 2019
1edd0e9
Review (jreback)
h-vetinari Jan 4, 2019
03c46cd
Merge remote-tracking branch 'upstream/master' into infer_skipna
h-vetinari Jan 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add kwarg to new call-sites
  • Loading branch information
@h-vetinari
h-vetinari committed Jan 3, 2019
commit ebd106382b3ad4e8016a446ca2e59f989d2f23fd
4 changes: 2 additions & 2 deletions pandas/core/reshape/merge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -962,8 +962,8 @@ def _maybe_coerce_merge_keys(self):
# object values are allowed to be merged
elif ((lk_is_object and is_numeric_dtype(rk)) or
(is_numeric_dtype(lk) and rk_is_object)):
inferred_left = lib.infer_dtype(lk)
inferred_right = lib.infer_dtype(rk)
inferred_left = lib.infer_dtype(lk, skipna=False)
inferred_right = lib.infer_dtype(rk, skipna=False)
bool_types = ['integer', 'mixed-integer', 'boolean', 'empty']
string_types = ['string', 'unicode', 'mixed', 'bytes', 'empty']

Expand Down