Skip to content

Test nested PandasArray #24993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 30, 2019
Merged

Test nested PandasArray #24993

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
558cdbe
REF: Move numpy tests down a directory
TomAugspurger Jan 29, 2019
38e7413
The fix
TomAugspurger Jan 29, 2019
9122bb6
implement skips
TomAugspurger Jan 29, 2019
86948a1
fixed skip message
TomAugspurger Jan 29, 2019
afb1bee
Merge remote-tracking branch 'upstream/master' into 24986-nested-array
TomAugspurger Jan 29, 2019
642b01a
py2 compat
TomAugspurger Jan 29, 2019
518315c
seperate file
TomAugspurger Jan 29, 2019
6d7e0d8
remove duplicate fixtures
TomAugspurger Jan 29, 2019
bf1efc9
Skip for old NumPy
TomAugspurger Jan 29, 2019
cc246c9
comment
TomAugspurger Jan 30, 2019
bea8de0
Merge remote-tracking branch 'upstream/master' into 24986-nested-array
TomAugspurger Jan 30, 2019
7cf5583
Update pandas/tests/extension/numpy_/conftest.py
jorisvandenbossche Jan 30, 2019
358df86
Update test_numpy_nested.py
TomAugspurger Jan 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed skip message
  • Loading branch information
@TomAugspurger
TomAugspurger committed Jan 29, 2019
commit 86948a1b52e67cbb432201ef499a685489320aa5
2 changes: 1 addition & 1 deletion pandas/tests/extension/numpy_/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@


def pytest_collection_modifyitems(config, items):
skip = pytest.mark.skip(reason="Skipping this because ...")
skip = pytest.mark.skip(reason="Skipping for nested data.")
for item in items:
# TODO: See if pytest has a better way to resolve the *value*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be eager to hear of a better way to do this. Right now, we rely on the name being like TestMethods::test_where_series[object-True] do determine if we should skip. Not the cleanest. Ideally we would be able to resolve that to the actual value, but pytest may not have that yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonjayhawkins any thoughts here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomAugspurger why don't you just add a marker to specific tests? (and skip on that)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not aware of a way for a test marker to get access to the value of another fixture.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we would be able to resolve that to the actual value, but pytest may not have that yet.

IIUC, from a test or fixture you get the value supplied to the fixture by including that (used by) fixture in the function signature. seems to work...

https://github.com/simonjayhawkins/pandas/blob/6ebf2c52d8925663a9242d3c58a069000b2c3f06/pandas/tests/io/formats/conftest.py#L141-L146

that would mean changing all the tests individually though. so this may not be what your after.

# supplied to a fixture. Right now .keywords gets things
Expand Down