Skip to content

[CLN] Excel Module Cleanups #25275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 20, 2019
Merged

[CLN] Excel Module Cleanups #25275

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7bbe910
Address comments of @gfyoung in #25153
tdamsma Feb 11, 2019
c98f72e
satisfy isort
tdamsma Feb 11, 2019
bc074ed
removed seemingly dead code as per suggestion @WillAyd
tdamsma Feb 12, 2019
62ce7db
remove test for registering custom excel extensions
tdamsma Feb 12, 2019
5e49439
Revert "remove test for registering custom excel extensions"
tdamsma Feb 13, 2019
cf3c5bc
Remove test for registering excel file with custom extension as this …
tdamsma Feb 13, 2019
e42b10c
trigger test rerun
tdamsma Feb 13, 2019
a82119a
improve docstring
tdamsma Feb 14, 2019
7f81675
imprve docstring
tdamsma Feb 14, 2019
03bc237
Merge commit '4a20d5b9e526435a53b7cb1dc0a819299d31f040' into excel-mo…
tdamsma Feb 17, 2019
f30ab5c
remove trailing whitespace
tdamsma Feb 17, 2019
9ef747f
Merge commit '659e0cae6be2d7ab3370cc7d8ab936bc3ee1b159' into excel-mo…
tdamsma Feb 18, 2019
19160fa
Apply suggestions from code review
WillAyd Feb 19, 2019
bcf053e
Improve docstrings as per WillAyd's suggestions
tdamsma Feb 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
trigger test rerun
  • Loading branch information
@tdamsma
tdamsma committed Feb 13, 2019
commit e42b10c3b3559cdb190b6c3f26569dd8bf241731
1 change: 0 additions & 1 deletion pandas/tests/io/test_excel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2380,7 +2380,6 @@ def check_called(func):
writer = ExcelWriter('something.xlsx')
assert isinstance(writer, DummyClass)
df = tm.makeCustomDataframe(1, 1)

check_called(lambda: df.to_excel('something.xlsx'))
check_called(
lambda: df.to_excel(
Expand Down