Skip to content

BUG: Avoid duplicating entire exploded column when joining back with origi… #28010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Sep 17, 2019
Merged

BUG: Avoid duplicating entire exploded column when joining back with origi… #28010

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
6dc8e94
Remove old whatsnew entry
Aug 29, 2019
6bcb970
Remove comment with issue number
Aug 19, 2019
97baf46
Rewrite
Aug 20, 2019
8d1fdc5
Remove commas after kwargs from autoformatting
Aug 20, 2019
e178a7b
Remove more trailing commas
Aug 20, 2019
8024fd6
Rewrite how string is formatted (for backwards compatibility)
Aug 20, 2019
2059de8
Add multiindex (named and unnamed) to test cases
Aug 20, 2019
dc80a94
Avoid having to keep track of index names
Aug 20, 2019
1f13e2f
Black autoformatting
Aug 20, 2019
437ee94
Add fix and test for case of partially named multiindex
Aug 21, 2019
522c769
Black autoformatting
Aug 21, 2019
52ba53b
Clean up
Aug 21, 2019
0b86a55
Simplify renaming index
Aug 21, 2019
63f2d47
Re-write in more readable way
Aug 29, 2019
82099b1
Use ABCMultiindex to assert type of index
Aug 29, 2019
0496af7
Add whatsnew entry
Aug 29, 2019
efd5463
Add whatsnew entry in v1.0.0.rst
Aug 30, 2019
06d1dc7
Rephrase whatsnew entry, name copy of self result rather than frame
Aug 30, 2019
1904564
Remove special-casing multiindex
Aug 30, 2019
586427c
further simplification using take
MarcoGorelli Sep 3, 2019
71a12fe
Fix merge conflict in whatsnew
MarcoGorelli Sep 15, 2019
e581e1c
Remove repetitive commands in test parametrization
MarcoGorelli Sep 15, 2019
9db4962
Further reformatting
MarcoGorelli Sep 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clean up
  • Loading branch information
@MarcoGorelli
Marco Gorelli authored and MarcoGorelli committed Sep 3, 2019
commit 52ba53b73c7f831df46c3a38b15ac5eae3afe8b2
1 change: 0 additions & 1 deletion pandas/core/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6260,7 +6260,6 @@ def explode(self, column: Union[str, Tuple]) -> "DataFrame":
raise ValueError("columns must be unique")

column_with_index = self[column].reset_index()

result = (
self.drop([column], axis=1)
.reset_index()
Expand Down