Skip to content

BUG: Timestamp+int should raise NullFrequencyError, not ValueError #28268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 8, 2019
Merged

BUG: Timestamp+int should raise NullFrequencyError, not ValueError #28268

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f597e55
merge upstream
jbrockmendel Sep 3, 2019
072f0da
remove unreachable
jbrockmendel Sep 3, 2019
bb0384d
remove unreached
jbrockmendel Sep 3, 2019
bf128fd
remove comment
jbrockmendel Sep 3, 2019
9b829a1
revert unnecessary
jbrockmendel Sep 3, 2019
b17b036
remove commented-out
jbrockmendel Sep 3, 2019
720eeb0
black
jbrockmendel Sep 3, 2019
72990a0
isort fixup
jbrockmendel Sep 3, 2019
08dc007
whatsnew
jbrockmendel Sep 3, 2019
0c942fc
Merge branch 'master' of https://github.com/pandas-dev/pandas into nfe
jbrockmendel Sep 4, 2019
f0ab301
move note to 1.0 file
jbrockmendel Sep 4, 2019
db93594
Merge branch 'master' of https://github.com/pandas-dev/pandas into nfe
jbrockmendel Sep 7, 2019
7a2667b
Merge branch 'master' of https://github.com/pandas-dev/pandas into nfe
jbrockmendel Sep 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
whatsnew
  • Loading branch information
@jbrockmendel
jbrockmendel committed Sep 3, 2019
commit 08dc007c08de722ebee3441c3834607a4daad40d
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v0.25.2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Categorical

Datetimelike
^^^^^^^^^^^^

- Addition and subtraction of integer or integer-dtype arrays with :class:`Timestamp` will now raise ``NullFrequencyError`` instead of ``ValueError`` (:issue:`28268`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to 1.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed+green

-
-
-
Expand Down