Skip to content

Pandas get_dummies validate columns input #28463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 22, 2019
Merged

Pandas get_dummies validate columns input #28463

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
87fa4ea
Updated Reshape.py to validate `columns` in `get_dummies`
R1j1t Sep 16, 2019
09a4f5e
added tests for the column validation
R1j1t Sep 16, 2019
ef2d577
updated test_reshape.py with PEP-8 code rec
R1j1t Sep 16, 2019
faa8f07
code formated using black
R1j1t Sep 16, 2019
81c2597
updated test_reshape.py
R1j1t Sep 17, 2019
3aa8749
updated file based on the changes in PR
R1j1t Sep 17, 2019
af99037
Update doc/source/whatsnew/v1.0.0.rst
R1j1t Sep 17, 2019
2353462
updated error message based on comments received
R1j1t Sep 17, 2019
7d68181
updated the test with the new error message
R1j1t Sep 17, 2019
ef1b9cd
Removed list-like object check
R1j1t Sep 20, 2019
38f13f9
Merge remote-tracking branch 'upstream/master' into R1j1t-master
TomAugspurger Sep 23, 2019
4da4149
whitespace fixup
WillAyd Sep 23, 2019
aea5019
Merge remote-tracking branch 'upstream/master' into R1j1t-master
WillAyd Oct 11, 2019
9cd8d40
Removed trailing space
R1j1t Oct 12, 2019
f266f47
Removed redundant value in test
R1j1t Oct 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed list-like object check 
based on the comments, i have removed the list-like objects check
  • Loading branch information
@R1j1t
R1j1t committed Sep 20, 2019
commit ef1b9cd729ee82bf8198e58acc9fec7d74177341
46 changes: 0 additions & 46 deletions pandas/tests/reshape/test_reshape.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,52 +608,6 @@ def test_get_dummies_all_sparse(self):
)
tm.assert_frame_equal(result, expected)

@pytest.mark.parametrize(
"values",
[
["baz", "zoo"],
np.array(["baz", "zoo"]),
pd.Series(["baz", "zoo"]),
pd.Index(["baz", "zoo"]),
],
)
def test_get_dummies_with_list_like_values(self, values):
# issue #28383
df = pd.DataFrame(
{
"bar": [1, 2, 3, 4, 5, 6],
"foo": ["one", "one", "one", "two", "two", "two"],
"baz": ["A", "B", "C", "A", "B", "C"],
"zoo": ["x", "y", "z", "q", "w", "t"],
}
)

result = pd.get_dummies(df, columns=values, dtype="int64")

data = [
[1, "one", 1, 0, 0, 0, 0, 0, 1, 0, 0],
[2, "one", 0, 1, 0, 0, 0, 0, 0, 1, 0],
[3, "one", 0, 0, 1, 0, 0, 0, 0, 0, 1],
[4, "two", 1, 0, 0, 1, 0, 0, 0, 0, 0],
[5, "two", 0, 1, 0, 0, 0, 1, 0, 0, 0],
[6, "two", 0, 0, 1, 0, 1, 0, 0, 0, 0],
]
columns = [
"bar",
"foo",
"baz_A",
"baz_B",
"baz_C",
"zoo_q",
"zoo_t",
"zoo_w",
"zoo_x",
"zoo_y",
"zoo_z",
]
expected = DataFrame(data=data, columns=columns)
tm.assert_frame_equal(result, expected)

@pytest.mark.parametrize("values", ["baz", "zoo"])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these two values testing meaningfully distinct cases?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought of adding 2 different values just for the check but they are testing the same case. I will remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one now!

def test_get_dummies_with_string_values(self, values):
# issue #28383
Expand Down