Skip to content

fix unnecessary sort in pd.read_json and orient="index" #28606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 9, 2019
Merged

fix unnecessary sort in pd.read_json and orient="index" #28606

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
101b4d2
fix unnecessary sort
KimDoubleB Sep 25, 2019
892c3e3
fix tests
KimDoubleB Sep 25, 2019
accf764
Py35 sort index
KimDoubleB Sep 25, 2019
f958bbd
Merge remote-tracking branch 'upstream/master' into sort
KimDoubleB Sep 26, 2019
e117e17
fix tests
KimDoubleB Sep 26, 2019
03f1432
modify the request part
KimDoubleB Sep 26, 2019
5dbdcdb
Merge branch 'master' into sort
KimDoubleB Oct 1, 2019
783a033
Merge remote-tracking branch 'upstream/master' into sort
KimDoubleB Oct 1, 2019
a3f2872
back to origin code
KimDoubleB Oct 1, 2019
c70ce73
Merge remote-tracking branch 'upstream/master' into sort
KimDoubleB Oct 1, 2019
b9317ff
add whatsnew
KimDoubleB Oct 1, 2019
5a93f93
Merge branch 'master' into sort
KimDoubleB Oct 8, 2019
7976a8b
isort error fix
KimDoubleB Oct 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
modify the request part
  • Loading branch information
@KimDoubleB
KimDoubleB committed Sep 26, 2019
commit 03f1432805e04d37312ac095e616c93b99af1b11
5 changes: 2 additions & 3 deletions pandas/core/indexes/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,9 +170,8 @@ def _union_indexes(indexes, sort=True):
result = indexes[0]
if isinstance(result, list):
if sort:
result = Index(sorted(result))
else:
result = Index(result)
result = sorted(result)
result = Index(result)
return result

indexes, kind = _sanitize_and_check(indexes)
Expand Down
3 changes: 1 addition & 2 deletions pandas/io/json/_json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1118,8 +1118,7 @@ def _parse_no_numpy(self):
orient="index",
)
if compat.PY35:
self.obj.sort_index(axis="columns", inplace=True)
self.obj.sort_index(axis="index", inplace=True)
self.obj = self.obj.sort_index(axis="columns").sort_index(axis="index")
elif orient == "table":
self.obj = parse_table_schema(json, precise_float=self.precise_float)
else:
Expand Down