Skip to content

ENH: Add ignore_index for df.sort_values and series.sort_values #30402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Dec 27, 2019
Merged

ENH: Add ignore_index for df.sort_values and series.sort_values #30402

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
7e461a1
remove \n from docstring
charlesdong1991 Dec 3, 2018
1314059
fix conflicts
charlesdong1991 Jan 19, 2019
8bcb313
Merge remote-tracking branch 'upstream/master'
charlesdong1991 Jul 30, 2019
1f9a4ce
Merge remote-tracking branch 'upstream/master' into fix_issue_30114
charlesdong1991 Dec 9, 2019
5f924c3
Merge remote-tracking branch 'upstream/master' into fix_issue_30114
charlesdong1991 Dec 22, 2019
d0a134f
Add ignore index for sort values
charlesdong1991 Dec 22, 2019
6d52765
black reformat
charlesdong1991 Dec 22, 2019
a31797d
add tests
charlesdong1991 Dec 22, 2019
b80f380
remove type hint to see if test passes
charlesdong1991 Dec 22, 2019
b997d3f
code change based on WA review
charlesdong1991 Dec 23, 2019
12d1260
restore reformat change on other parts
charlesdong1991 Dec 23, 2019
4ff2493
revert change
charlesdong1991 Dec 23, 2019
e9d63f4
change bool
charlesdong1991 Dec 23, 2019
70ffec7
remove annotation
charlesdong1991 Dec 23, 2019
b4245d7
remove for series
charlesdong1991 Dec 23, 2019
f9e7ec2
add ignore_index for series
charlesdong1991 Dec 23, 2019
d95a89f
keep consistency
charlesdong1991 Dec 23, 2019
f241e67
revert change
charlesdong1991 Dec 23, 2019
7f9846a
resolve conflict
charlesdong1991 Dec 23, 2019
bbb4754
restore change
charlesdong1991 Dec 23, 2019
3c37eb9
code change based on WA and JR reviews
charlesdong1991 Dec 24, 2019
4ce9f43
better english
charlesdong1991 Dec 24, 2019
0f89aa2
skip annotation
charlesdong1991 Dec 24, 2019
d02b651
code change on JR review
charlesdong1991 Dec 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove annotation
  • Loading branch information
@charlesdong1991
charlesdong1991 committed Dec 23, 2019
commit 70ffec7367287c36a3612ee75ad018e44a1994bf
2 changes: 1 addition & 1 deletion pandas/core/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4704,7 +4704,7 @@ def sort_values(
inplace=False,
kind="quicksort",
na_position="last",
ignore_index: bool = False,
ignore_index=False,
):
inplace = validate_bool_kwarg(inplace, "inplace")
axis = self._get_axis_number(axis)
Expand Down
2 changes: 1 addition & 1 deletion pandas/core/series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2693,7 +2693,7 @@ def sort_values(
inplace=False,
kind="quicksort",
na_position="last",
ignore_index: bool = False,
ignore_index=False,
):
"""
Sort by the values.
Expand Down