Skip to content

PERF: Cache MultiIndex.levels #31651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 4, 2020
Merged

PERF: Cache MultiIndex.levels #31651

merged 2 commits into from
Feb 4, 2020

Conversation

TomAugspurger
Copy link
Contributor

Closes #31648.

This should have been caught by the benchmark MultiIdnex.time_index_slice. Confirming that now..

@TomAugspurger TomAugspurger added Performance Memory or execution speed performance Indexing Related to indexing on series/frames, not to indexes themselves MultiIndex labels Feb 4, 2020
@TomAugspurger TomAugspurger added this to the 1.0.1 milestone Feb 4, 2020
@TomAugspurger TomAugspurger mentioned this pull request Feb 4, 2020
Closed
@jbrockmendel
Copy link
Member

LGTM

@TomAugspurger TomAugspurger merged commit 3b2b0d3 into pandas-dev:master Feb 4, 2020
@TomAugspurger TomAugspurger deleted the 31616-cache-index branch February 4, 2020 19:26
@lumberbot-app
Copy link

lumberbot-app bot commented Feb 4, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 1.0.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 3b2b0d31ad5bfc004e7ab5bb772ea4100d5bebda
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #31651: PERF: Cache MultiIndex.levels'
  1. Push to a named branch :
git push YOURFORK 1.0.x:auto-backport-of-pr-31651-on-1.0.x
  1. Create a PR against branch 1.0.x, I would have named this PR:

"Backport PR #31651 on branch 1.0.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@TomAugspurger
Copy link
Contributor Author

Ah, just realized I forgot a release note, sorry.

Will push that and handle the backport in a bit.

TomAugspurger added a commit to TomAugspurger/pandas that referenced this pull request Feb 4, 2020
@TomAugspurger
PERF: Cache MultiIndex.levels (pandas-dev#31651)
18e24a9 
* PERF: Cache MultiIndex.levels

Closes pandas-dev#31648

* fixup tests
@TomAugspurger TomAugspurger mentioned this pull request Feb 4, 2020
Merged
TomAugspurger added a commit that referenced this pull request Feb 4, 2020
@TomAugspurger
Backport PR #31651: PERF: Cache MultiIndex.levels (#31664)
fb5ec37
@topper-123 topper-123 mentioned this pull request Mar 13, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees

No one assigned

Labels

Indexing Related to indexing on series/frames, not to indexes themselves MultiIndex Performance Memory or execution speed performance

Projects

None yet

Milestone

1.0.1

Development

Successfully merging this pull request may close these issues.

PERF: Indexing a multi-index is a lot slower

3 participants

@TomAugspurger @jbrockmendel @jorisvandenbossche