Skip to content

[BACKLOG-40823] - Upgrade the Tomcat version from current to 10.x.x with Java 17 #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

SahithiKommagani6
Copy link

This pull request updates the project to use Jakarta EE APIs instead of Java EE APIs. It includes changes to replace javax.servlet imports with jakarta.servlet, updates the pom.xml dependencies to align with Jakarta EE, and introduces new method overrides to support Jakarta Servlet features.

Migration to Jakarta EE

  • Replaced all javax.servlet imports with jakarta.servlet in multiple files, including HttpConnectionHelper.java, InternalHttpServletRequest.java, InternalHttpServletResponse.java, ServletInputStreamWrapper.java, and ServletOutputStreamWrapper.java. This ensures compatibility with Jakarta EE APIs. [1] [2] [3] [4] [5]

  • Updated pom.xml to replace Java EE dependencies (javax.servlet-api, jersey-servlet, jersey-spring, jsr311-api, etc.) with Jakarta EE equivalents (jakarta.servlet-api, jersey-container-servlet, jersey-spring6, etc.). Added exclusions to prevent conflicts. (F8a3b1ddL13R13, [1] [2] [3]

Support for Jakarta Servlet Features

  • Added method overrides in InternalHttpServletRequest.java to support Jakarta Servlet features like changeSessionId, getRequestId, getProtocolRequestId, getServletConnection, and upgrade. These methods return default values or null for now. [1] [2]

  • Added method overrides in ServletInputStreamWrapper.java and ServletOutputStreamWrapper.java for Jakarta Servlet features such as isFinished, isReady, setReadListener, and setWriteListener. These methods currently return default values or perform no actions. [1] [2]

Test Updates

  • Updated test files (HttpConnectionHelperTest.java, InternalHttpServletRequestTest.java, InternalHttpServletResponseTest.java) to replace javax.servlet imports with jakarta.servlet. This ensures test compatibility with the updated API. [1] [2] [3]

@SahithiKommagani6 SahithiKommagani6 requested a review from a team as a code owner July 15, 2025 12:02
@buildguy

This comment has been minimized.

@buildguy
Copy link
Collaborator

❌ Build failed in 25s

Build command:

mvn clean verify -B -e -Daudit -Djs.no.sandbox

❗ No tests found!

Errors:

Filtered log (click to expand)

script returned exit code 1

ℹ️ This is an automatic message

Copy link

@smmribeiro smmribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants