PG-1603 Make pg_basebackup work with encrypted WAL #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Supersedes #473 |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (82.22%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #513 +/- ##
=====================================================
+ Coverage 82.00% 82.22% +0.22%
=====================================================
Files 24 25 +1
Lines 3162 3179 +17
Branches 514 515 +1
=====================================================
+ Hits 2593 2614 +21
+ Misses 460 456 -4
Partials 109 109
🚀 New features to boost your workflow:
|
dutow
approved these changes
Aug 8, 2025
When WAL is streamed during the backup (default mode), it comes in unencrypted. But we need keys to encrypt it. For now, we expect that the user would put `pg_tde` dir containing the `1664_key` and `1664_providers` into the destination directory before starting the backup. We encrypt the streamed WAL according to internal keys. No `pg_tde` dir means no streamed WAL encryption.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When WAL is streamed during the backup (default mode), it comes in unencrypted. But we need keys to encrypt it. For now, we expect that the user would put
pg_tdedir containing the1664_keyand1664_providersinto the destination directory before starting the backup. And we encrypt streamed WAL according to the internal keys. Nopg_tdedir means no streamed WAL encryption.Why I created
TDEXLogCryptBuffer():stream->walmethod->opsis an interface and there are at least four implementation of thewrite()method which accepts a buffer as argument. I thought about usingTDEXLogSmgrInitWriteReuseKey()+pipe+xlog_smgr->seg_write(), but my experiments show that it is possible for pg_basebackup to start a stream from a couple of "wal keys back", therefore reusing of the last key won't work.