TODO:sample_discrete_maps updated to handle torch tensors natively #2213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DarshanCode2005 How is this any better than what we were already doing? This still has to test whether the array is torch tensor or a numpy array. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement PyTorch tensor support in
sample_discrete_maps(previously TODO)This PR addresses the outstanding TODO in
pgmpy/utils/mathext.pyby enabling thesample_discrete_mapsfunction to natively handle PyTorch tensors, alongside existing support for NumPy arrays.By avoiding conversions between tensors and arrays, this enhancement:
Backward compatibility with NumPy inputs is fully maintained.
This completes the planned extension and makes
sample_discrete_mapsmore versatile and efficient for hybrid ML and PGMs applications.