Fix GH-19801: address leak when calling var_dump() with recursion in __debugInfo()#19837
Merged
alexandre-daubois merged 1 commit intophp:PHP-8.3from Sep 16, 2025
Merged
Conversation
Member
|
What's wrong with zend_array_release (or similar)? Then you don't need zval wrapping |
alexandre-daubois
force-pushed
the
vd-leak
branch
from
4083b32 to
7a38609
Compare
Member
Author
|
Nothing wrong apart that I forgot about it, tests still green with it on my machine. PR updated 🙂 |
arnaud-lb
reviewed
Sep 15, 2025
…in __debugInfo()
alexandre-daubois
force-pushed
the
vd-leak
branch
from
7a38609 to
dcf860b
Compare
arnaud-lb
approved these changes
Sep 15, 2025
arnaud-lb
reviewed
Sep 15, 2025
Member
arnaud-lb
left a comment
arnaud-lb
left a comment
There was a problem hiding this comment.
Looks good to me! Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #19801
Also fixes the same issue in
debug_zval_dump(). I wasn't able to reproduce the issue withvar_export()however.Note:
ext/standard/tests/general_functions/debug_zval_dump_gh19801_memory_leak.phptshould be updated on upmerge to addpackedto the internal array representation