Closed
Conversation
To make installation experience better instead of only outputting warning when re2c is not present this patch also exits if the PHP lexer file(s) were not generated yet and re2c is not present on the system.
Member
|
+1 for consistency with the Windows build system |
nikic
reviewed
Nov 23, 2018
nikic
reviewed
Nov 23, 2018
nikic
approved these changes
Nov 25, 2018
Member
Author
|
Applied via 67b9108 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make installation experience better instead of only outputting warning when
re2cis not present this patch also exits if the PHP lexer file(s) were not generated yet andre2cis not present on the system.(it checks if
Zend/zend_language_scanner.cfile is present)Related to #3673