Fix #53251: bindtextdomain with null dir doesn't return old value#6631
Closed
cmb69 wants to merge 1 commit intophp:PHP-7.4from
Closed
Fix #53251: bindtextdomain with null dir doesn't return old value#6631cmb69 wants to merge 1 commit intophp:PHP-7.4from
cmb69 wants to merge 1 commit intophp:PHP-7.4from
Conversation
Apparently, users expect `bindtextdomain` and `bind_textdomain_codeset` with `null` as second argument to work like their C counterparts, namely to return the previously set value. Thus, we support that.
nikic
approved these changes
Jan 25, 2021
Member
nikic
left a comment
nikic
left a comment
There was a problem hiding this comment.
I didn't read the full discussion in the bug report, but the change makes sense to me.
php-pulls
pushed a commit
to php/doc-en
that referenced
this pull request
Jan 25, 2021
php-pulls
pushed a commit
to php/doc-ja
that referenced
this pull request
Jan 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently, users expect
bindtextdomainandbind_textdomain_codesetwith
nullas second argument to work like their C counterparts,namely to return the previously set value. Thus, we support that.
This issue may not be regarded as bug at all, but I still suggest to merge into PHP-8.0 at least.