Fix #81407: shmop_open won't attach and causes php to crash#7448
Closed
cmb69 wants to merge 3 commits intophp:PHP-7.4from
Closed
Fix #81407: shmop_open won't attach and causes php to crash#7448cmb69 wants to merge 3 commits intophp:PHP-7.4from
cmb69 wants to merge 3 commits intophp:PHP-7.4from
Conversation
We need to allocate buffers for the file mapping names which are large enough for all potential keys (`key_t` is defined as `int` on Windows).
Member
On azure. |
It's probably never a good idea to use hard-coded keys (always use `ftok()`), but to reliably reproduce this Windows specific issue we need to, and it shouldn't be an issue on that OS.
Member
Author
|
Ah, thanks! Guess it's best to run this test on Windows only. |
Its string representation is longer than that of INT_MAX, and it's permissible here.
nikic
approved these changes
Sep 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to allocate buffers for the file mapping names which are large
enough for all potential keys (
key_tis defined asinton Windows).A cleaner solution would be to print the keys as hexadecimal numbers, and to use
2*sizeof(key_t)to get its size. Not sure if anybody relies on the decimal keys; maybe better change that for "master" only?And we may want to avoid the (likely harmless) integer overflow which currently may happen.