Closed
Conversation
|
This fix looks like a crazy hack, the real solution to this is to change the comparison functions for identifiers not to be locale dependent, not hack around a specific locale and its treatment of the letter "i" in a low-level copying function. |
|
Comment on behalf of stas at php.net: other fix will be done. |
php-pulls
pushed a commit
that referenced
this pull request
Apr 1, 2013
php-pulls
pushed a commit
that referenced
this pull request
Apr 1, 2013
* PHP-5.5: Fixed issue #79 (Optimization Problem/Bug) fix coverage data for the opcache optimizer
EdmondDantes
added a commit
to true-async/php-src
that referenced
this pull request
Feb 3, 2026
…adlock detection
EdmondDantes
added a commit
to true-async/php-src
that referenced
this pull request
Feb 3, 2026
In async context (inside coroutines), pg_connect() now always creates a new connection instead of reusing cached connections. This prevents race conditions when multiple coroutines try to use the same PostgreSQL connection simultaneously. Changes: - Skip connection cache lookup when ZEND_ASYNC_CURRENT_COROUTINE is set - Don't add async connections to the cache to ensure isolation - Update tests to use separate connections per coroutine
EdmondDantes
added a commit
to true-async/php-src
that referenced
this pull request
Feb 8, 2026
…nection closure on factory failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch to avoid locale-aware lowercasing for letter 'I' in zend_str_tolower() and friends.