Declare ext/standard constants in stubs - part 2#9426
Merged
kocsismate merged 1 commit intophp:masterfrom Aug 26, 2022
Merged
Conversation
cmb69
approved these changes
Aug 26, 2022
Member
cmb69
left a comment
cmb69
left a comment
There was a problem hiding this comment.
This solution makes sense to me. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially, I wanted to declare these constants in basic_functions.stub.php, but it would have required to include lots of headers in basic_functions.c, and the result would still have been questionable, since a lot of constants are conditionally declared via
#ifdefs. That's why I went with this solution for now, but I'm open for any feedback!