windows.php.net index is broken#3
Closed
gordol wants to merge 2 commits intophp:masterfrom
gordol:index_fix
Closed
windows.php.net index is broken#3gordol wants to merge 2 commits intophp:masterfrom gordol:index_fix
gordol wants to merge 2 commits intophp:masterfrom
gordol:index_fix
Conversation
…n C:\domains\windows.php.net\templates\header.php on line 4
Contributor
|
Thanks for the PR. This mirror repo wasn't synced for a while, but it works now. Could you please check and rebase, if needed? Thanks. |
Contributor
|
I can confirm the issue. PR itself looks fine to be merged without rebasing. |
weltling
reviewed
Apr 25, 2017
docroot/index.php
Outdated
| define('CUR_PATH', dirname(__FILE__) . DIRECTORY_SEPARATOR); | ||
| //define('TPL_PATH', CUR_PATH . 'templates' . DIRECTORY_SEPARATOR); | ||
|
|
||
| $title_page = 'Home' |
Author
There was a problem hiding this comment.
yeah, i caught that way earlier. check latest commit.
september 2014. :)
looks like you figured it out, and merged already though. 👍
Contributor
There was a problem hiding this comment.
Yeah, thanks for the PR in any case. We're now also synced with the upstream repo, so PRs can target the current state.
php-pulls
pushed a commit
that referenced
this pull request
Apr 25, 2017
Contributor
|
Changes merged, while patch was not available anymore. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP Notice: Undefined variable: title_page in C:\domains\windows.php.net\templates\header.php on line 4Added a default page title var for index, and also prepended an @ to the $title_page variable call in header.php.
Double fixed.