Skip to content

#241 Add start and end file positions to method locations #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 30, 2022
Merged

#241 Add start and end file positions to method locations #243

merged 2 commits into from
Mar 30, 2022

Conversation

LeoVie
Copy link
Contributor

@LeoVie LeoVie commented Mar 30, 2022

This solves #241

@LeoVie
Copy link
Contributor Author

LeoVie commented Mar 30, 2022

Saw my fault, this should be green now. :)

@LeoVie
Copy link
Contributor Author

LeoVie commented Mar 30, 2022

I don't really get, why this is still red.

There seem to be some pgp key issues on the windows runners https://github.com/phpDocumentor/Reflection/runs/5751208572?check_suite_focus=true

And I don't know, if the issues on the ubuntu runners are related to my changes or if they are occuring somehow random: https://github.com/phpDocumentor/Reflection/runs/5751214156?check_suite_focus=true

@jaapio
Copy link
Member

jaapio commented Mar 30, 2022

Please ignore the windows builds for now... we do have this issue on all repo's :-(

@LeoVie
Copy link
Contributor Author

LeoVie commented Mar 30, 2022

Okay. Can you give me a hint about the failing ubuntu runs? For example this one: https://github.com/phpDocumentor/Reflection/runs/5751214156?check_suite_focus=true

This seems to be related to the lowest composer dependencies, because here the error does not occur: https://github.com/phpDocumentor/Reflection/runs/5751207400?check_suite_focus=true

If I'm interpreting this right, this has nothing to do with changes of this pull request. Is this right?

@jaapio
Copy link
Member

jaapio commented Mar 30, 2022

Ah, sorry about that, I left a comment a bit too early, as I had to go for lunch.

You may ignore all of this, I pushed a change yesterday to do some more boundary testing on component constraints. And it seems that we are not strict enough for some of the dependencies. The allowed range should be more narrow.

I will fix that in a new PR. Your changes are looking good!.

@jaapio jaapio merged commit 99f89c7 into phpDocumentor:5.x Mar 30, 2022
@jaapio
Copy link
Member

jaapio commented Mar 30, 2022

@LeoVie was this all what's needed for your feature request?

@LeoVie
Copy link
Contributor Author

LeoVie commented Mar 30, 2022

@jaapio In this repository, yes. I will create a pull request in the original issue at phpDocumentor/phpDocumentor#3154 for the other required changes, once there is a new build of phpDocumentor/Reflection.

Thanks for merging! :)

@LeoVie LeoVie deleted the rfc/241-full-line-and-column-location branch March 30, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants