Skip to content

[WIP] Use printObject to print import attributes #17329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

fisker
Copy link
Member

@fisker fisker commented Apr 9, 2025

Description

Fixes #17071

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Copy link

pkg-pr-new bot commented Apr 9, 2025

Open in StackBlitz

npm i https://pkg.pr.new/prettier@17329

commit: ce338fd

Copy link

netlify bot commented Apr 9, 2025

Deploy Preview for prettier ready!

Name Link
🔨 Latest commit ce338fd
🔍 Latest deploy log https://app.netlify.com/sites/prettier/deploys/67f60209d961990008556947
😎 Deploy Preview https://deploy-preview-17329--prettier.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fisker fisker force-pushed the print-import-attributes branch from 7e84b6b to 72a58cc Compare April 9, 2025 04:52
Comment on lines 151 to 153
hasNewlineInRange(
options.originalText,
locStart(node),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sosukesuzuki Any idea how to fix this? In other nodes they all starts with {, how do we find { here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[js] Consider printing import assertions on multiple lines
1 participant