-
Notifications
You must be signed in to change notification settings - Fork 111
Set release tag from time and date #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set release tag from time and date #431
Conversation
Set tag from time and date
Thanks for this! I think it's a good idea to automatically create the |
Just saw your comment in Slack. What is the |
@runemadsen It is used to set the name of the release: |
Right now I'm automatically creating the unique tag, not the version name. I'm actually not sure where the idea of having a unique tag for each release started or if it is necessary but I emulated it here. Automatically generating the version name would be tricky, since we may want to get the website out of Beta at some point, or bump it up from version 7 to 8 at some point and this is subjective and not a decision we can easily automate. |
Thanks for that. The unique tag is only needed for the GitHub release, since GitHub uses this to make a Git tag in the current HEAD of the branch. I was just wondering whether we need the |
Changed version to title and tweaked input descriptions
@runemadsen: Gotcha! I made this change. Do these commit look ok? I'm kinda new to the whole GH workflows thing :) |
Looks good to me! I've never set an ENV variable like this, but give it a whirl and see how it goes! |
Hmm, yeah that doesn't seem to be the proper way to set env variables. I'll fix this before merging. Edit: the normal way to set environment variables doesn't work for dynamic variables. this is promising: https://github.com/orgs/community/discussions/26342 |
properly set the GitHub environment variable (untested)
@runemadsen It worked! Here's what I ended up with:
|
Great! |
Make a unique tag for workflow releases from the time and date.