Skip to content

gh-100540: Remove obsolete '--with-system-ffi' configure option #100544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2022
Merged

gh-100540: Remove obsolete '--with-system-ffi' configure option #100544

merged 1 commit into from
Dec 28, 2022

Conversation

zware
Copy link
Member

@zware zware commented Dec 26, 2022 •
edited by bedevere-bot
Loading

It has had no effect on non-macOS platforms for a long time, and has had
the non-obvious effect of invoking pkg_config and not setting
-DUSING_APPLE_OS_LIBFFI on macOS since GH-22855.

@zware
pythongh-100540: Remove obsolete '--with-system-ffi' configure option
7a7dd58 
It has had no effect on non-macOS platforms for a long time, and has had
the non-obvious effect of invoking `pkg_config` and not setting
`-DUSING_APPLE_OS_LIBFFI` on macOS since pythonGH-22855.
@zware zware added 3.12 only security fixes OS-mac build The build process and cross-build topic-ctypes extension-modules C modules in the Modules dir labels Dec 26, 2022
@zware zware self-assigned this Dec 26, 2022
@zware zware requested a review from a team December 26, 2022 22:19
@bedevere-bot bedevere-bot mentioned this pull request Dec 26, 2022
Closed
@zware zware requested a review from erlend-aasland December 26, 2022 22:44
@zware zware added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 26, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @zware for commit 7a7dd58 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 26, 2022
erlend-aasland
erlend-aasland approved these changes Dec 28, 2022
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@zware zware merged commit 25590eb into python:main Dec 28, 2022
@zware zware deleted the remove_--with-system-ffi branch December 28, 2022 19:36
Gusse500 added a commit to Gusse500/LFS-Norsk that referenced this pull request Nov 1, 2023
@Gusse500
python: Fjern --with-system-ffi
2edfb93 
Dette alternativet er fjernet av oppstrøms i 3.12.

Link: python/cpython#100544
Poltern added a commit to Poltern/lfs-ru that referenced this pull request Nov 1, 2023
@Poltern
python: Remove --with-system-ffi
4714d57 
This option is removed by upstream in 3.12.

Link: python/cpython#100544
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees

@zware zware

Labels
3.12 only security fixes build The build process and cross-build extension-modules C modules in the Modules dir OS-mac topic-ctypes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zware @bedevere-bot @erlend-aasland