Skip to content

Conversation

gaogaotiantian
Copy link
Member

@gaogaotiantian gaogaotiantian commented Mar 27, 2023

Copy link
Contributor

@artemmukhin artemmukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one more thing I would like to mention. I think it would be better to use instr instead of inst as an abbreviation for instruction, in both commands and source code. From what I have seen in the project, inst is also used for instance, whereas instr is primarily used for instruction.

@gaogaotiantian
Copy link
Member Author

There is one more thing I would like to mention. I think it would be better to use instr instead of inst as an abbreviation for instruction, in both commands and source code. From what I have seen in the project, inst is also used for instance, whereas instr is primarily used for instruction.

Using instr in the source code sounds like a good idea because that's how dis does it. However, in gdb and lldb, I think they just use stepi and nexti for the LONG version and that kind of makes sense. I think I'll go with that - si and stepi, do not use stepinst or stepinstr.

Copy link
Contributor

@artemmukhin artemmukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using stepi and nexti as long versions of commands makes sense for me as well 👍

@gaogaotiantian gaogaotiantian marked this pull request as ready for review April 8, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants