Skip to content

gh-104015: Fix direct invocation of test_dataclasses #104017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2023
Merged

gh-104015: Fix direct invocation of test_dataclasses #104017

merged 1 commit into from
Apr 30, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Apr 30, 2023 •
edited by AlexWaygood
Loading

Local tests do pass now:

» ./python.exe Lib/test/test_dataclasses.py 
........................................................................................................................................................................................................................................
----------------------------------------------------------------------
Ran 232 tests in 1.113s

OK

Closes #104015

@sobolevn sobolevn requested a review from AlexWaygood April 30, 2023 16:51
@sobolevn sobolevn requested a review from ericvsmith as a code owner April 30, 2023 16:51
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Apr 30, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 30, 2023
Closed
@AlexWaygood AlexWaygood changed the title gh-104015: Fix direct invokation of test_dataclasses gh-104015: Fix direct invocation of test_dataclasses Apr 30, 2023
AlexWaygood
AlexWaygood approved these changes Apr 30, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexWaygood AlexWaygood self-assigned this Apr 30, 2023
wookie184
wookie184 approved these changes Apr 30, 2023
View reviewed changes
Copy link
Contributor

@wookie184 wookie184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this fixes the issue, thanks!

@AlexWaygood AlexWaygood added the 3.12 only security fixes label Apr 30, 2023
@AlexWaygood AlexWaygood enabled auto-merge (squash) April 30, 2023 16:59
@AlexWaygood AlexWaygood merged commit 654d44b into python:main Apr 30, 2023
carljm added a commit to carljm/cpython that referenced this pull request May 1, 2023
@carljm
Merge branch 'main' into supermon
159b2aa 
* main: (26 commits)
  pythongh-104028: Reduce object creation while calling callback function from gc (pythongh-104030)
  pythongh-104036: Fix direct invocation of test_typing (python#104037)
  pythongh-102213: Optimize the performance of `__getattr__` (pythonGH-103761)
  pythongh-103895: Improve how invalid `Exception.__notes__` are displayed (python#103897)
  Adjust expression from `==` to `!=` in alignment with the meaning of the paragraph. (pythonGH-104021)
  pythongh-88496: Fix IDLE test hang on macOS (python#104025)
  Improve int test coverage (python#104024)
  pythongh-88773: Added teleport method to Turtle library (python#103974)
  pythongh-104015: Fix direct invocation of `test_dataclasses` (python#104017)
  pythongh-104012: Ensure test_calendar.CalendarTestCase.test_deprecation_warning consistently passes (python#104014)
  pythongh-103977: compile re expressions in platform.py only if required (python#103981)
  pythongh-98003: Inline call frames for CALL_FUNCTION_EX (pythonGH-98004)
  Replace Netlify with Read the Docs build previews (python#103843)
  Update name in acknowledgements and add mailmap (python#103696)
  pythongh-82054: allow test runner to split test_asyncio to execute in parallel by sharding. (python#103927)
  Remove non-existing tools from Sundry skiplist (python#103991)
  pythongh-103793: Defer formatting task name (python#103767)
  pythongh-87092: change assembler to use instruction sequence instead of CFG (python#103933)
  pythongh-103636: issue warning for deprecated calendar constants (python#103833)
  Various small fixes to dis docs (python#103923)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@ericvsmith ericvsmith Awaiting requested review from ericvsmith

+1 more reviewer

@wookie184 wookie184 wookie184 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@AlexWaygood AlexWaygood

Labels
3.12 only security fixes skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running test_dataclasses file directly fails
4 participants
@sobolevn @wookie184 @AlexWaygood @bedevere-bot